Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove periods from list in personalizing-your-profile#setting-your-l… #33590

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

moosecodes
Copy link
Contributor

@moosecodes moosecodes commented Jun 20, 2024

Closes:
#33586

What's being changed (if available, include any code snippets, screenshots, or gifs):

Update an unordered list.

There are 2 bullet point items under the location and timezone settings section that were incomplete sentences. Therefore, the periods at the end of those list items were removed.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Jun 20, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
account-and-profile/setting-up-and-managing-your-github-profile/customizing-your-profile/personalizing-your-profile.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836
Copy link
Contributor

@moosecodes Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into github:main with commit a39f386 Jun 20, 2024
43 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@ewiseg

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account-and-profile Content relating to account and profile content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove periods from list in personalizing-your-profile#setting-your-location-and-time-zone
3 participants