Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put visibility info closer to decision info #3262

Merged
merged 5 commits into from
Feb 2, 2021

Conversation

felicitymay
Copy link
Contributor

@felicitymay felicitymay commented Jan 28, 2021

Why:

Fixes: #2418

The current documentation on creating a new repository for your GitHub Pages site explained that only public repositories were supported for free accounts, but this was in the header information for the topic and not where people were making a decision about repository visibility.

What's being changed:

I've made the following changes:

  1. Moved the existing warning about privacy to the section about setting up GitHub Pages for an existing repository.
  2. Revised the introduction to the section on creating a new repository for GitHub Pages to remind users with GitHub Free and GitHub Free for organizations accounts to create a public repository.

You can see the impact of these changes here:

Check off the following:

@welcome
Copy link

welcome bot commented Jan 28, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@felicitymay
Copy link
Contributor Author

Now that the staging site is deployed, I've updated the PR summary to include links to the live and staging versions of the topic affected to make it easier to review.

@felicitymay felicitymay marked this pull request as draft January 29, 2021 12:14
@felicitymay felicitymay marked this pull request as ready for review February 1, 2021 10:36
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have any questions!

data/reusables/pages/new-or-existing-repo.md Outdated Show resolved Hide resolved
@felicitymay felicitymay merged commit 409fed0 into main Feb 2, 2021
@felicitymay felicitymay deleted the 2418-visibility-reminder branch February 2, 2021 08:55
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Copy link

@aleksandrpidgurskij aleksandrpidgurskij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y mi neznayt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a Github pages repo as private will not work even after changing visibility
4 participants