-
Notifications
You must be signed in to change notification settings - Fork 60.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node:18 in examples of actions with containers #28442
Conversation
The image `node:14.16` is old, and doesn't work with `actions/checkout@v4` which might contribute to issues such as actions/checkout#1474 This change uses `node:18` for the example, which is the LTS version of node for one more month. https://github.com/nodejs/release#release-schedule
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
This comment was marked as spam.
This comment was marked as spam.
@tvalenta Thank you for opening a PR and linking it to your issue! ✨ I'll get this triaged for review! ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this update @tvalenta! ✨
I'll go ahead and help merge this
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes: #28440
What's being changed (if available, include any code snippets, screenshots, or gifs):
The image
node:14.16
is old, and doesn't work withactions/checkout@v4
which might contribute to issues such as actions/checkout#1474This change uses
node:18
for the example, which is the LTS version of node for one more month.https://github.com/nodejs/release#release-schedule
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.