Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some ghcr docker call examples had a typo when specifying image tag #262

Merged
merged 2 commits into from
Oct 10, 2020

Conversation

tspascoal
Copy link
Contributor

@tspascoal tspascoal commented Oct 8, 2020

Why:

Some of the docker examples had a typo when specifying the image tag

What's being changed:

Changed a dot from colon (on two separate calls) , the separator between the image name and the tag is a colon, since a dot was being used the tag was part of the tag name which was not the intended.

Check off the following:

@welcome
Copy link

welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@tspascoal Thanks for opening a pull request! Please fill out the rest of the pull request template to explain what changes you've made and we'll get this up for review 🌟

@tspascoal
Copy link
Contributor Author

Done.

@janiceilene janiceilene added packages This issue or pull request should be reviewed by the docs packages team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 9, 2020
Copy link
Contributor

@rachmari rachmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tspascoal thank you for fixing this bug! 🔧🐛

This looks great. 🙌 I'll go ahead and merge it in for you. :shipit: 🚀 👏

@rachmari rachmari merged commit bbda22c into main Oct 10, 2020
@rachmari rachmari deleted the tspascoal/fix-ghcr-typo branch October 10, 2020 01:25
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@tspascoal
Copy link
Contributor Author

@all-contributors please add tspascoal for Documentation

@allcontributors
Copy link
Contributor

@tspascoal

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 8560

@janiceilene
Copy link
Contributor

@tspascoal I think all contributors should be working again 🎉 If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@tspascoal
Copy link
Contributor Author

@all-contributors please add tspascoal for Documentation

@allcontributors
Copy link
Contributor

@tspascoal

I've put up a pull request to add @tspascoal! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants