Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing number to string in example yaml #25146

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Changing number to string in example yaml #25146

merged 1 commit into from
Apr 26, 2023

Conversation

SHA65536
Copy link
Contributor

This example shows supplying go-version as a number 1.15, this works for version up to 1.19, but with 1.20, it will turn it into a number (1.2) and then back into a string "1.2" making the action use Go 1.2 instead of 1.20.

Why:

I saw someone face this issue and realized the problem came from this example on the docs.

Closes: #25145

What's being changed (if available, include any code snippets, screenshots, or gifs):

Go version type from 1.5 to '1.5' to prevent wrong version after conversion to number.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

This example shows supplying go-version as a number 1.15, this works for version up to 1.19, but with 1.20, it will turn it into a number (1.2) and then back into a string "1.2" making the action use Go 1.2 instead of 1.20.
@welcome
Copy link

welcome bot commented Apr 21, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 21, 2023
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/automating-builds-and-tests/building-and-testing-go.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 21, 2023
@cmwilson21
Copy link
Contributor

@SHA65536 Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

AriyannaFisher

This comment was marked as spam.

Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! We'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Apr 26, 2023
@skedwards88 skedwards88 added this pull request to the merge queue Apr 26, 2023
Merged via the queue into github:main with commit 908859b Apr 26, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go version as number instead of string in yaml example
4 participants