Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny headline adjustment for the Issue event types page #2004

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

abjerner
Copy link
Contributor

@abjerner abjerner commented Dec 11, 2020

Why:

The Issue event types page has a number of Event object properties headlines. All but one are H4s, as a single is a H3 instead.

As a H3 gets a link in the page navigation to the right, I thought I would change that to a H4 as well 😉

Since this is such a tiny change, I haven't created an issue.

Check off the following:

@welcome
Copy link

welcome bot commented Dec 11, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@abjerner Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@abjerner
Copy link
Contributor Author

@janiceilene I've updated the PR now. I wasn't sure about check list, but makes more sense now that the tests have completed.

@janiceilene
Copy link
Contributor

Thanks so much @abjerner! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Dec 11, 2020
@lucascosti lucascosti self-assigned this Dec 16, 2020
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @abjerner!

@lucascosti lucascosti merged commit 5a81f46 into github:main Dec 16, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants