Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More on how INPUT_<VARIABLE_NAME> works or doesn't #19883

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Aug 16, 2022

This is a follow-up to #7693

Why:

actions/runner#665 (comment)

What's being changed (if available, include any code snippets, screenshots, or gifs):

Removing prose that hints that a composite action would get INPUT_ prefixed environment variables.

Instead, just point to the top of the doc where I previously added text that seems to describe what's happening.

Before

image

After

image

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/creating-actions/metadata-syntax-for-github-actions.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

👋 @jsoref Thanks for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added help wanted Anyone is welcome to open a pull request to fix this issue content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team help wanted Anyone is welcome to open a pull request to fix this issue labels Aug 17, 2022
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thanks @jsoref!

@lucascosti lucascosti enabled auto-merge (squash) August 22, 2022 07:09
@lucascosti lucascosti added the ready to merge This pull request is ready to merge label Aug 22, 2022
@lucascosti lucascosti merged commit 3f5df14 into github:main Aug 22, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@jsoref jsoref deleted the composite-actions-do-not-get-INPUT_ branch August 22, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants