Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info on where posts are published to #1931

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Conversation

szunami
Copy link
Contributor

@szunami szunami commented Dec 9, 2020

When following this tutorial, I found it very difficult to actually view the post I just created.

The default behavior is documented here: https://jekyllrb.com/docs/front-matter/#predefined-global-variables

Why:

When creating my first post, I found it very difficult to view the post on my published site. I imagine this is a pain point for others.

I opened #1933 to discuss this.

What's being changed:

This PR adds a reference URL where posts are published to.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

When following this tutorial, I found it very difficult to actually view the post I just created.

The default behavior is documented here: https://jekyllrb.com/docs/front-matter/#predefined-global-variables
@welcome
Copy link

welcome bot commented Dec 9, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@szunami Thanks so much for opening a PR! I'll get this triaged for review ✨

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 17, 2020
@szunami
Copy link
Contributor Author

szunami commented Dec 17, 2020

Posting to ward off the stale bot

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 17, 2020
@janiceilene
Copy link
Contributor

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 25, 2020
@szunami
Copy link
Contributor Author

szunami commented Dec 27, 2020

:)

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Dec 27, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 3, 2021
@szunami
Copy link
Contributor Author

szunami commented Jan 3, 2021

(:

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Jan 5, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 12, 2021
@szunami
Copy link
Contributor Author

szunami commented Jan 12, 2021

@janiceilene whoops I missed a loop; I don't think I have the perms to remove the stale label. Can you help me out here? ty

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 12, 2021
@felicitymay felicitymay linked an issue Jan 15, 2021 that may be closed by this pull request
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @szunami - thank you so much for your patience. It's great to have your contribution as it'll save other users getting stuck at the last part of the instructions.

Your changes look good to me.

@felicitymay felicitymay merged commit 4475452 into github:main Jan 15, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficulty finding a post I just published from my Github Page
3 participants