Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Configuring Git for GitHub Desktop" article #18146

Merged
merged 25 commits into from
Jun 3, 2022

Conversation

steveward
Copy link
Member

@steveward steveward commented May 23, 2022

Why:

Closes #4033

What's being changed:

  • Updated the "Configuring Git for GitHub Desktop" article with the new dropdown option for selecting an email address to use for committing
  • Added a section describing how to set an email address for commits on a per-repository basis
  • Updated a bunch of screenshots and created new ones where needed
  • Updated and renamed 'paste-email-git-config' to 'select-email-git-config' reusable since you can now use a dropdown to select an email address

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@steveward steveward added content This issue or pull request belongs to the Docs Content team desktop Content related to GitHub Desktop labels May 23, 2022
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 23, 2022
@steveward steveward removed the triage Do not begin working on this issue until triaged by the team label May 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
desktop/contributing-and-collaborating-using-github-desktop/working-with-your-remote-repository-on-github-or-github-enterprise/changing-a-remotes-url-from-github-desktop.md fpt
fpt
desktop/installing-and-configuring-github-desktop/configuring-and-customizing-github-desktop/configuring-git-for-github-desktop.md fpt
fpt

@luxevwood

This comment was marked as spam.

Copy link

@jkidd11 jkidd11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assets/images/help/desktop/mac-select-default-branch-name.png

@steveward steveward marked this pull request as ready for review May 26, 2022 18:24
@steveward steveward requested a review from lecoursen May 26, 2022 18:41
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great @steveward! ✨ In one of my comments I asked you to add another brief paragraph, and I'll give this another quick review after you do!

@steveward
Copy link
Member Author

@lecoursen this should be ready for another review! Thanks!

lecoursen
lecoursen previously approved these changes Jun 2, 2022
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so great @steveward! 🎉:sparkles: I left two small suggestions to consider, but this looks ready to merge after you 👀 those.

…sktop/working-with-your-remote-repository-on-github-or-github-enterprise/changing-a-remotes-url-from-github-desktop.md

Co-authored-by: Laura Coursen <[email protected]>
@steveward steveward enabled auto-merge June 3, 2022 14:46
@steveward steveward merged commit c1c5fda into main Jun 3, 2022
@steveward steveward deleted the desktop-configuring-git branch June 3, 2022 14:58
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team desktop Content related to GitHub Desktop
Projects
None yet
4 participants