Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance "About GitHub Advanced Security" page #15253

Merged
merged 13 commits into from
Feb 10, 2022
Merged

Enhance "About GitHub Advanced Security" page #15253

merged 13 commits into from
Feb 10, 2022

Conversation

lucie-docs
Copy link
Contributor

@lucie-docs lucie-docs commented Feb 8, 2022 •
edited
Loading

Why:

Closes https://github.com/github/docs-content/issues/6200

What's being changed:

Added a table breaking down GHAS availabilty for public and private repos for ftp and ghec.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 8, 2022
@github-actions github-actions bot temporarily deployed to docs-15253--enhance-about-ghas February 8, 2022 15:02 Inactive
@lucie-docs lucie-docs changed the title Enhance about ghas page Enhance "About GitHub Advanced Security" page Feb 8, 2022
@github-actions github-actions bot temporarily deployed to docs-15253--enhance-about-ghas February 8, 2022 15:16 Inactive
@github-actions github-actions bot temporarily deployed to docs-15253--enhance-about-ghas February 8, 2022 15:24 Inactive
@github-actions github-actions bot temporarily deployed to docs-15253--enhance-about-ghas February 8, 2022 15:28 Inactive
@github-actions github-actions bot temporarily deployed to docs-15253--enhance-about-ghas February 8, 2022 15:48 Inactive
@lucie-docs
Copy link
Contributor Author

lucie-docs commented Feb 8, 2022 •
edited
Loading

Ok, this PR is ready for review now!

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 9, 2022
@ramyaparimi
Copy link
Contributor

@lucie-docs Thanks so much for opening a PR! I'll get this triaged for review ⚡

@mchammer01 mchammer01 self-requested a review February 10, 2022 08:05
mchammer01
mchammer01 previously approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucie-docs - thanks for adding these tables ✨
I've made some simplifications to the versioning and I'm going to apply my suggestions shortly.

content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to docs-15253--enhance-about-ghas February 10, 2022 08:53 Inactive
mchammer01
mchammer01 reviewed Feb 10, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tidying up

content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to docs-15253--enhance-about-ghas February 10, 2022 08:58 Inactive
@github-actions github-actions bot temporarily deployed to docs-15253--enhance-about-ghas February 10, 2022 09:01 Inactive
mchammer01
mchammer01 reviewed Feb 10, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully fixing versioning

content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Outdated Show resolved Hide resolved
content/get-started/learning-about-github/about-github-advanced-security.md Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to docs-15253--enhance-about-ghas February 10, 2022 09:18 Inactive
mchammer01
mchammer01 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨
Versioning all working as expected, wohoo!

@github-actions github-actions bot temporarily deployed to docs-15253--enhance-about-ghas February 10, 2022 09:28 Inactive
@mchammer01 mchammer01 merged commit 0049664 into github:main Feb 10, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@lucie-docs lucie-docs deleted the enhance-about-ghas-page branch February 10, 2022 11:19
m0dul3 referenced this pull request Feb 27, 2022
@ramyaparimi
Update CONTRIBUTING.md (#22398)
78d71e3 
* Update CONTRIBUTING.md

* Update CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucie-docs @ramyaparimi @mchammer01