Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Prettier for Yaml formatting #1323

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 13, 2020

Why:

@chiedo already fixed the security related issues of #128, this adds the remaining consistency TODO

What's being changed:

  • Prettier to fix indenting/quoting across files with CI job to check
  • Manually adjust list styles to "-" style
  • Ignore all translated files from automated formatting
  • Drop redundant CI env variable

Check off the following:

@nschonni nschonni requested review from a team as code owners November 13, 2020 20:56
@nschonni nschonni force-pushed the prettier-yml branch 2 times, most recently from 271a18b to ef3cca8 Compare November 13, 2020 21:35
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Related to github#128
- Prettier to fix indenting/quoting across files
- Manually adjust list styles to "-" style
- Ignore all translated files from automated formatting
- Drop redundant CI env variable
@janiceilene
Copy link
Contributor

Thanks @nschonni! I'll get this triaged 🌟

@janiceilene janiceilene added the engineering Will involve Docs Engineering label Nov 17, 2020
@chiedo chiedo merged commit 1bd4435 into github:main Nov 17, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@chiedo
Copy link
Contributor

chiedo commented Nov 17, 2020

Thank you @nschonni !!!

This was referenced Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants