Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed small typo in script/README file #13138

Closed
wants to merge 3 commits into from
Closed

Fix: Fixed small typo in script/README file #13138

wants to merge 3 commits into from

Conversation

bobychaudhary
Copy link

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@bobychaudhary bobychaudhary requested a review from a team as a code owner December 18, 2021 09:32
@welcome
Copy link

welcome bot commented Dec 18, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@arzpgh60 arzpgh60 mentioned this pull request Dec 18, 2021
Closed
1 task
ramyaparimi
ramyaparimi approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobychaudhary
Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge labels Dec 20, 2021
@bobychaudhary bobychaudhary changed the title Fix: Fixed small type in script/README file Fix: Fixed small typo in script/README file Dec 20, 2021
@bobychaudhary
Copy link
Author

What "Lost" ?

@bobychaudhary bobychaudhary requested review from ramyaparimi and removed request for a team January 1, 2022 17:30
@ramyaparimi
Copy link
Contributor

@bobychaudhary I spoke with the team and want to let you know that changes to script/ directory are not accepted. I am going to close this PR now and apologize for the confusion 💛

Thanks so much for contributing to our docs 💖

@ramyaparimi ramyaparimi closed this Jan 4, 2022
auto-merge was automatically disabled January 4, 2022 20:14

Pull request was closed

@RanaAhmed2020 RanaAhmed2020 mentioned this pull request Nov 30, 2023
Open
@ryan-ally ryan-ally mentioned this pull request Nov 30, 2023
Open
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Dec 1, 2023
Open
@Sarrac3873 Sarrac3873 mentioned this pull request May 13, 2024
Open
@ryan-ally ryan-ally mentioned this pull request May 14, 2024
Open
@aliscco aliscco mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramyaparimi ramyaparimi Awaiting requested review from ramyaparimi

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobychaudhary @ramyaparimi