chore: flatten ifs for fkirc/skip-duplicate-actions #1115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Each of the sub-steps except on that only applies when the previous steps fails are skipped if the "should skip" job evaluates to
true
. It was figured out with the js-lint job that this "Skipped" jobs still allow merging of the "Required" jobs.What's being changed:
Hoist the
if
condition for the test jobs to the root, and remove the duplicate checksif
s on the sub-stepsCheck off the following: