Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: flatten ifs for fkirc/skip-duplicate-actions #1115

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 6, 2020

Why:

Each of the sub-steps except on that only applies when the previous steps fails are skipped if the "should skip" job evaluates to true. It was figured out with the js-lint job that this "Skipped" jobs still allow merging of the "Required" jobs.

What's being changed:

Hoist the if condition for the test jobs to the root, and remove the duplicate checks ifs on the sub-steps

Check off the following:

@nschonni nschonni requested a review from a team as a code owner November 6, 2020 03:21
@nschonni
Copy link
Contributor Author

nschonni commented Nov 6, 2020

@JamesMGreene I copied over what we learned in #862

Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏼 Nice improvement.

@janiceilene janiceilene added the engineering Will involve Docs Engineering label Nov 6, 2020
@chiedo chiedo merged commit 08f2fa2 into github:main Nov 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@nschonni nschonni deleted the flatten-skip-duplicate-jobs branch November 9, 2020 15:16
Octomerger pushed a commit that referenced this pull request Oct 29, 2021
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
Co-authored-by: Lana Brindley <[email protected]>
Co-authored-by: Fabrízio de Royes Mello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants