Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version check #40

Closed
wants to merge 1 commit into from
Closed

Fix version check #40

wants to merge 1 commit into from

Conversation

zrax
Copy link

@zrax zrax commented May 7, 2024

Previously, Vim 8.1 would pass the version check, but fail later in the script due to attempting to use vim 9.0 features.

Copy link

github-actions bot commented May 7, 2024

At the moment we are not accepting contributions to the repository.

Feedback for Copilot.vim can be given in the Copilot community discussions.

@github-actions github-actions bot closed this May 7, 2024
@tpope
Copy link
Collaborator

tpope commented May 7, 2024

How is it failing, exactly? The design is deliberate; users on 8.1 still get a :Copilot command to tell them the version is too old.

@zrax
Copy link
Author

zrax commented May 7, 2024

This is what I see from 8.1.1847 (Ubuntu 20.04) at startup, without the change:

Error detected while processing /home/zrax/.vim/pack/github/start/copilot.vim/plugin/copilot.vim:
line   56:
E216: No such group or event: InsertLeavePre       * call s:Event('InsertLeavePre')
Press ENTER or type command to continue

@tpope
Copy link
Collaborator

tpope commented May 8, 2024

Thanks, it wasn't reproducible on 8.1.0000. I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants