Skip to content

Migrate from optional-dependencies to dependency-groups #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harupy wants to merge 2 commits into from
Closed

Migrate from optional-dependencies to dependency-groups #168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5792df
Use dependency-groups
harupy Jan 24, 2026
6a4fca8
Fix arg order
harupy Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ Python SDK for programmatic control of GitHub Copilot CLI via JSON-RPC.
## Installation

```bash
pip install -e ".[dev]"
pip install -e --group dev .

Copilot AI Jan 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated installation snippet mixes pip install with a --group flag, but pip itself doesn’t support --group—that flag is specific to uv and will cause this command to fail. To keep the instructions working after switching to dependency groups, this line should either use a valid pip command (without --group) or be rewritten to use uv in a way that correctly installs the dev group (similar to the uv sync example below).

Suggested change
pip install -e --group dev .
pip install -e .

Copilot uses AI. Check for mistakes.

@harupy harupy Jan 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip >= v25.1 supports --group: https://pip.pypa.io/en/latest/news/#v25-1

# or
uv pip install -e ".[dev]"
uv sync

@brettcannon brettcannon Feb 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do note that due to the uv.lock file that is checked in that this is not equivalent to the command it's replacing.

```

## Quick Start
Expand Down
2 changes: 1 addition & 1 deletion python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Repository = "https://github.com/github/copilot-sdk"
where = ["."]
include = ["copilot*"]

[project.optional-dependencies]
[dependency-groups]
dev = [
"ruff>=0.1.0",
"ty>=0.0.2",
Expand Down
19 changes: 11 additions & 8 deletions python/uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading