Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: github actions cleanup #206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: github actions cleanup #206

wants to merge 1 commit into from

Conversation

jmeridth
Copy link
Member

Pull Request

Proposed Changes

  • add stale workflow
  • switch to umutable actions on ones that allow it (closes 8 security warnings)
  • solve actionlint issues
    • group commands instead of instead of individual redirects
    • double quote variable to prevent globbing and word splitting

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance or breaking

@jmeridth
chore: github actions cleanup
a149582 
- [x] add stale workflow
- [x] switch to umutable actions on ones that allow it (closes 8 security warnings)
- [x] solve actionlint issues
  - [x] group commands instead of instead of individual redirects
  - [x] double quote variable to prevent globbing and word splitting

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth self-assigned this Nov 20, 2024
Copilot
Copilot AI reviewed Nov 20, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • .github/workflows/docker-ci.yml: Evaluated as low risk
  • .github/workflows/python-ci.yml: Evaluated as low risk

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@sutterj sutterj Awaiting requested review from sutterj sutterj is a code owner

@zkoppert zkoppert Awaiting requested review from zkoppert zkoppert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@jmeridth jmeridth

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmeridth