C#: Set proxy environment variables, if Dependabot proxy is detected #18029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbg
force-pushed
the
mbg/csharp/set-proxy-cert-file
branch
from
c5c1260
to
9731006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of work to enable private package registries to be used in default setup.
The existing default setup workflow will initialise the Dependabot package proxy if a private package registry configuration is configured. The host, port, and certificate used by the proxy are then passed to CodeQL in the
analyzestep.The changes in this PR modify the C# extractor to recognise when the corresponding environment variables are set. If so, we use the data from those environment variables to:
dotnetvia theHTTP_PROXYandHTTPS_PROXYenvironment variables.dotnetviaSSL_CERT_FILE.In testing so far, this works fine on Linux with fairly arbitrary versions of
dotnet. It does not seem to work on macOS and likely also does not work on Windows.