-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++: Implement compilation_build_mode #18009
base: main
Are you sure you want to change the base?
Conversation
cpp/ql/lib/semmlecode.cpp.dbscheme
Outdated
* 1 = manual | ||
* 2 = auto | ||
*/ | ||
#keyset[id, mode] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to do something like the following (at the very least in a comment). That should give you some identifiers to refer to in the extractor instead of having to hardcoded constants.
case @compilation_build_mode.mode of
1 = @build_mode_none
| 2 = @build_mode_manual
| 3 = @build_mode_auto
;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I did not realise this works in comments as well!
description: Implement compilation_build_mode/2 | ||
compatibility: backwards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to delete the new table.
@@ -78,7 +78,7 @@ | |||
</e> | |||
<e> | |||
<k>@using_enum_declaration</k> | |||
<v>1</v> | |||
<v>0</v> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you didn't run the internal workflow we have to generate additional data from out tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the generate-db-stats workflow, downloaded the artefact, and merge was apparently successful:
[13:53:32] [DCA info] Normalizing stats by user-provided 'exprs'.
[13:53:32] [DCA info] Using stats from tests '~/Downloads/testsuite_stats.xml'.
[13:53:32] [DCA info] Using static stat files from /Users/calum/projects/codeql-dca/static-stats/cpp.
what am I missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not possible for me to tell from this alone. Let's discuss internally?
0948649
to
4136f8d
Compare
cpp/downgrades/f0156f5f88ab5967c79162012c20f30600ca5ebf/upgrade.properties
Outdated
Show resolved
Hide resolved
…e.properties Co-authored-by: Jeroen Ketema <[email protected]>
Pull Request checklist
All query authors
.qhelp
. See the documentation in this repository.Internal query authors only
.ql
,.qll
, or.qhelp
files. See the documentation (internal access required).