Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Added support for [Object, Map].groupBy ES2024 feature #18008

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Napalys
Copy link
Contributor

@Napalys Napalys commented Nov 18, 2024

Added taint-steps for ES2024 features:

DCA analyses shows that overall time is fine.

@github-actions github-actions bot added the JS label Nov 18, 2024
@Napalys Napalys force-pushed the napalys/ES2024-group-functions branch from f9096dc to a957e00 Compare November 20, 2024 13:03
@Napalys Napalys marked this pull request as ready for review November 21, 2024 11:15
@Napalys Napalys requested a review from a team as a code owner November 21, 2024 11:15
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise looks good 👍

javascript/ql/lib/semmle/javascript/Collections.qll Outdated Show resolved Hide resolved
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Do another DCA run to be sure.
Merge if that looks OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants