Skip to content

Java: Add more neutrals and improve java.net.URL models - #16062

Merged
atorralba merged 2 commits into
github:mainfrom
atorralba:atorralba/java/more-neutrals
Mar 27, 2024
Merged

Java: Add more neutrals and improve java.net.URL models#16062
atorralba merged 2 commits into
github:mainfrom
atorralba:atorralba/java/more-neutrals

Conversation

@atorralba

Copy link
Copy Markdown
Contributor

Adds more neutral models to help the model generator ignore certain callables.

This is similar to #15906, in the sense that it adds neutral models to prevent the model generator from generating summaries for them. These models were spotted while evaluating #14919.

Also, this PR improves the precision of certain URL models by using synthetic fields so that the parts of a URL are tainted separately. The reasoning is:

  • Control over the host: full URL object tainted.
  • Control over the path, query, and/or fragment: synthetic field path tainted.
  • Control over the protocol or port: no taint.

Adds more neutral models to help the model generator ignore certain callables.

Also improves the precision of certain URL models by using synthetic fields so that the parts of a URL are tainted separately.
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

  • Changes to framework-coverage-java.rst:
-    Java Standard Library,``java.*``,10,746,239,80,,9,,,25
+    Java Standard Library,``java.*``,10,760,240,80,,9,,,26
-    Totals,,308,18962,2559,338,16,128,33,1,409
+    Totals,,308,18976,2560,338,16,128,33,1,410
  • Changes to framework-coverage-java.csv:
- java.net,22,3,24,,,,1,1,,,,,,,,,,,,,,,,,,,,,,,,,,,,20,,,,,,,,,,,,,3,24,
+ java.net,23,3,31,,,,1,1,,,,,,,,,,,,,,,,,,,,,,,,,,,,21,,,,,,,,,,,,,3,31,
- java.security,21,,,,,11,10,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
+ java.security,21,,7,,,11,10,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,3,4

owen-mc
owen-mc previously approved these changes Mar 26, 2024
Comment thread java/ql/lib/ext/java.net.model.yml Outdated
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
@atorralba
atorralba merged commit b617667 into github:main Mar 27, 2024
@atorralba
atorralba deleted the atorralba/java/more-neutrals branch March 27, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants