Java: Add more neutrals and improve java.net.URL models - #16062
Merged
Conversation
Adds more neutral models to help the model generator ignore certain callables. Also improves the precision of certain URL models by using synthetic fields so that the parts of a URL are tainted separately.
Contributor
Click to show differences in coveragejavaGenerated file changes for java
- Java Standard Library,``java.*``,10,746,239,80,,9,,,25
+ Java Standard Library,``java.*``,10,760,240,80,,9,,,26
- Totals,,308,18962,2559,338,16,128,33,1,409
+ Totals,,308,18976,2560,338,16,128,33,1,410
- java.net,22,3,24,,,,1,1,,,,,,,,,,,,,,,,,,,,,,,,,,,,20,,,,,,,,,,,,,3,24,
+ java.net,23,3,31,,,,1,1,,,,,,,,,,,,,,,,,,,,,,,,,,,,21,,,,,,,,,,,,,3,31,
- java.security,21,,,,,11,10,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
+ java.security,21,,7,,,11,10,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,3,4 |
owen-mc
previously approved these changes
Mar 26, 2024
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
owen-mc
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more neutral models to help the model generator ignore certain callables.
This is similar to #15906, in the sense that it adds neutral models to prevent the model generator from generating summaries for them. These models were spotted while evaluating #14919.
Also, this PR improves the precision of certain URL models by using synthetic fields so that the parts of a URL are tainted separately. The reasoning is:
pathtainted.