Java: Fix provenance of Map.Entry.copyOf models - #15774
Merged
atorralba merged 1 commit intoMar 1, 2024
Merged
Conversation
aschackmull
approved these changes
Mar 1, 2024
Contributor
|
Should it be "df-manual", or just "manual"? The df-gen model didn't account for |
Contributor
Author
|
I'd say if the generator tips us into manually writing something, we can give it attribution. But happy to change it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@owen-mc I missed this while reviewing #15767, but I think the provenance should be
-manualinstead of-generatedsince we manually reviewed these (which gives them a bit more weight in certain dataflow calculations).