Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: Fix flow through && #15602

Merged
merged 6 commits into from
Feb 14, 2024
Merged

JS: Fix flow through && #15602

merged 6 commits into from
Feb 14, 2024

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Feb 13, 2024 •
edited
Loading

This removes the data flow edge from x to x && y. Since only falsy values can propagate through we usually do not care about this data flow.

@asgerf
JS: Fix flow through &&
7122a75 
This is a long-standing bug we've been unable to fix due to noise from type inference.
@github-actions github-actions bot added the JS label Feb 13, 2024
@asgerf asgerf marked this pull request as ready for review February 13, 2024 21:47
@asgerf asgerf requested a review from a team as a code owner February 13, 2024 21:47
erik-krogh
erik-krogh previously approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

But maybe add a test in one of the taint-tracking queries that would previously produce an FP.

@asgerf asgerf merged commit 75a95ff into github:main Feb 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erik-krogh erik-krogh erik-krogh approved these changes

Assignees
No one assigned
Labels
documentation JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asgerf @erik-krogh