Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Correct dotnet test change note. #13440

Closed
wants to merge 1 commit into from
Closed

C#: Correct dotnet test change note. #13440

wants to merge 1 commit into from

Conversation

michaelnebel
Copy link
Contributor

No description provided.

@michaelnebel michaelnebel requested a review from a team as a code owner June 13, 2023 09:25
@michaelnebel michaelnebel mentioned this pull request Jun 13, 2023
Merged
mbg
mbg reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but will this change have any effect if this note was already included in last week's release branch?

@michaelnebel
Copy link
Contributor Author

michaelnebel commented Jun 13, 2023 •
edited
Loading

Looks fine, but will this change have any effect if this note was already included in last week's release branch?

Ah yes, it made it into the release that was started last week - thank you for reminding me (so no - it won't have any effect)!! I don't think this change is important enough that we need to update/incorporate it in the release branch (even though I think it was just updated today as well).
@hvitved : Is it somehow possible to communicate mistakes in change notes or should we just accept the inaccuracy?

@hvitved
Copy link
Contributor

hvitved commented Jun 14, 2023

@hvitved : Is it somehow possible to communicate mistakes in change notes or should we just accept the inaccuracy?

I think this typo is so minor that we don't need to patch the change notes in the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbg mbg mbg left review comments

Assignees
No one assigned
Labels
C# documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelnebel @hvitved @mbg