Skip to content

Commit

Permalink
C++: Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
calumgrant committed Nov 22, 2024
1 parent 4fa8c6a commit 60155ce
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cpp/ql/src/change-notes/2024-11-22-too-few-arguments.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
---
category: minorAnalysis
---
* The "Call to function with fewer arguments than declared parameters" query (`cpp/too-few-arguments`) query produces no results if the function has been implicitly declared.
* The "Call to function with fewer arguments than declared parameters" query (`cpp/too-few-arguments`) query no longer produces results if the function has been implicitly declared.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ void test(int *argv[]) {
not_yet_declared1(1); // BAD (GOOD for everything except for cpp/implicit-function-declaration)
not_yet_declared2(1); // BAD (GOOD for everything except for cpp/implicit-function-declaration)
not_yet_declared2(ca); // BAD (GOOD for everything except for cpp/mistyped-function-arguments)
not_yet_declared2(); // GOOD
not_yet_declared2(); // BAD [NOT DETECTED] (GOOD for everything except for cpp/too-few-arguments)

declared_empty_defined_with(); // BAD
declared_empty_defined_with(1); // GOOD
Expand Down

0 comments on commit 60155ce

Please sign in to comment.