Always include BQRS in results archive #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
charisk
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
This looks reasonable to me.
My only question is whether we have an assumption anywhere that only a single file should exist in the zip. I can't imagine we do, but it would be good to double check if you haven't (a good way would be by running a MRVA using this branch).
|
Thanks! I've tested with this branch and everything is conveniently handled (or ignored) on the VS Code side 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of choosing whether to include SARIF or BQRS results in the results download, we always include at least BQRS. This is so that users have to option to display raw results in the MRVA results view, even if SARIF is available.
See internal linked issue for more details!