Skip to content

Update DoNotPerformFileOperationsOnDevices.ql #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jketema merged 1 commit into from
Mar 24, 2023
Merged

Update DoNotPerformFileOperationsOnDevices.ql #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions c/cert/src/rules/FIO32-C/DoNotPerformFileOperationsOnDevices.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ module TaintedPathConfiguration implements DataFlow::ConfigSig {
}
}

module TaintedPath = TaintTracking::Make<TaintedPathConfiguration>;
module TaintedPath = TaintTracking::Global<TaintedPathConfiguration>;

from
FileFunction fileFunction, Expr taintedArg, FlowSource taintSource,
Expand All @@ -98,7 +98,7 @@ where
not isExcluded(taintedArg, IO3Package::doNotPerformFileOperationsOnDevicesQuery()) and
taintedArg = sinkNode.getNode().asIndirectArgument() and
fileFunction.outermostWrapperFunctionCall(taintedArg, callChain) and
TaintedPath::hasFlowPath(sourceNode, sinkNode) and
TaintedPath::flowPath(sourceNode, sinkNode) and
taintSource = sourceNode.getNode()
select taintedArg, sourceNode, sinkNode,
"This argument to a file access function is derived from $@ and then passed to " + callChain + ".",
Expand Down