Skip to content

Produce separate SARIF file for quality-queries alerts #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jun 27, 2025
Merged

Produce separate SARIF file for quality-queries alerts #2935

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
3963bf4
Interpret results for quality queries and store as separate SARIF file
mbg Jun 16, 2025
aba8788
Upload both SARIF files in `quality-queries` check
mbg Jun 16, 2025
3a7544e
Check SARIF with quality results for expected configuration
mbg Jun 16, 2025
320f7b0
Resolve `code-quality` alias
mbg Jun 16, 2025
22444a6
Add ability to use different filters in `findSarifFilesInDir`
mbg Jun 17, 2025
45b3bec
Upload quality SARIFs to CQ endpoint
mbg Jun 17, 2025
f183422
Allow the same category once for each type of upload
mbg Jun 17, 2025
6abacdb
Fix `getSarifFilePaths` not using right filter
mbg Jun 17, 2025
f7fbaa0
Support all default query suites and resolve them
mbg Jun 23, 2025
5189159
Add test for modified `findSarifFilesInDir`
mbg Jun 24, 2025
af32bc6
Add test for modified `validateUniqueCategory`
mbg Jun 24, 2025
9b9286a
Add test for `resolveQuerySuiteAlias`
mbg Jun 24, 2025
86f47e8
Add some more comments
mbg Jun 24, 2025
2c76207
Upload `.quality.sarif` files to CQ service in `upload-sarif` action
mbg Jun 25, 2025
e382508
Prototyping adding quality queries when running queries
mbg Jun 25, 2025
79049d9
Fix `config-queries.qls` location
mbg Jun 25, 2025
768fc17
Rename `resolveQuerySuiteAlias` parameter
mbg Jun 26, 2025
27db6cb
Document `queries` parameter for `databaseRunQueries`
mbg Jun 26, 2025
71dd633
Rename `SARIF_UPLOAD_TARGET`
mbg Jun 26, 2025
08955db
Move `.sarif` predicates into `UploadTarget` instances and rename
mbg Jun 26, 2025
9ec0bb9
Fix incorrect `getSarifFilePaths` call in `upload-sarif` action
mbg Jun 26, 2025
ad6046f
Avoid default arguments with historical values
mbg Jun 26, 2025
7b3d150
Use `findSarifFilesInDir` in `upload-sarif` to avoid error when there…
mbg Jun 27, 2025
3e95091
Add test workflow for `upload-sarif` with quality results
mbg Jun 27, 2025
10a3e4b
Fix formatting
mbg Jun 27, 2025
362ebf8
Check both SARIF files in `quality-queries.yml` test
mbg Jun 27, 2025
65d1e45
Rename `SARIF_UPLOAD_ENDPOINT` members
mbg Jun 27, 2025
aa72dda
Merge branch 'main' into mbg/interpret-cq-results
mbg Jun 27, 2025
2830b75
Add changelog entry
mbg Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/__quality-queries.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/analyze-action.js.map
View file
Open in desktop

Large diffs are not rendered by default.

42 changes: 40 additions & 2 deletions lib/analyze.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading