Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup #2580

Merged
merged 6 commits into from
Nov 6, 2024
+99 −80
Merged

Minor cleanup #2580

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16e8ccc
spelling: in case
jsoref Nov 4, 2024
756aa64
spelling: macos
jsoref Nov 4, 2024
d5e7384
Strip trailing whitespace generated by ruamel-yaml
jsoref Nov 3, 2024
1e6d67b
Give expected-queries-runs permissions
jsoref Nov 3, 2024
688ea53
Fix publish-immutable-action version
jsoref Nov 3, 2024
3b7b85f
Conditionally clear runner cache
jsoref Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/expected-queries-runs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ jobs:
CODEQL_ACTION_TEST_MODE: true
timeout-minutes: 45
runs-on: ubuntu-latest
permissions:
contents: read
security-events: write
Comment on lines +25 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? CODEQL_ACTION_TEST_MODE should prevent the sarif from being uploaded.

Maybe this is all that is necessary (in order to check out the repo):

    permissions:
      contents: read

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected Queries Tests
This run of the CodeQL Action does not have permission to access Code Scanning API endpoints. As a result, it will not be opted into any experimental features. This could be because the Action is running on a pull request from a fork. If not, please ensure the Action has the 'security-events: write' permission. Details: Resource not accessible by integration
https://github.com/check-spelling-sandbox/github-codeql-action/actions/runs/11648653925

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably something about running in a fork. It's not a problem to leave it in.

steps:
- name: Check out repository
uses: actions/checkout@v4
Expand Down