Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a compatibility table to the README #2273

Merged
merged 4 commits into from
May 9, 2024
Merged

Add a compatibility table to the README #2273

merged 4 commits into from
May 9, 2024

Conversation

aeisenberg
Copy link
Contributor

Specifies the versions of the action, CLI and GHES that are jointly compatible.

When reviewing, please make sure this is table is clear to read and easy to maintain as we release new versions of the action.

Merge / deployment checklist

  • [n/a] Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • [n/a] Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner May 6, 2024 21:39
@aeisenberg aeisenberg force-pushed the aeisenberg/specify-versions branch from 86af32d to 37ba75b Compare May 7, 2024 15:06
henrymercer
henrymercer reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will help clear up something that has created confusion.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@aeisenberg aeisenberg force-pushed the aeisenberg/specify-versions branch from 37ba75b to 92c7c0d Compare May 7, 2024 20:31
@aeisenberg
Add a compatibility table to the README
e50fb8f 
Specifies the versions of the action, CLI and GHES that are jointly compatible.
@aeisenberg aeisenberg force-pushed the aeisenberg/specify-versions branch from 92c7c0d to e50fb8f Compare May 7, 2024 20:58
henrymercer
henrymercer reviewed May 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@aeisenberg
Copy link
Contributor Author

Oops. I just merged a previous PR that put the changelog note in the wrong place. Let me fix that.

henrymercer
henrymercer reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there was a merge in the changelog file that didn't go entirely right, otherwise LGTM.

@aeisenberg
Copy link
Contributor Author

I think that was already fixed in d234275, unless there's something I missed.

@henrymercer
Copy link
Contributor

Oh I see, the merge conflict was actually on main.

henrymercer
henrymercer approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aeisenberg aeisenberg merged commit def4d2c into main May 9, 2024
320 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/specify-versions branch May 9, 2024 15:13
@github-actions github-actions bot mentioned this pull request May 13, 2024
Merged
8 tasks
@henrymercer henrymercer mentioned this pull request May 13, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeisenberg @henrymercer