fix handling of backport changelog #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
previously approved these changes
Apr 16, 2024
henrymercer
reviewed
Apr 16, 2024
.github/update-release-branch.py
Outdated
| @@ -187,14 +187,18 @@ def process_changelog_for_backports(source_branch_major_version, target_branch_m | |||
|
|
|||
| # until we find the first section, just duplicate all lines | |||
| while True: | |||
| found_first_section = False | |||
There was a problem hiding this comment.
You could make not found_first_section the while condition to save a few lines of code, but not blocking.
There was a problem hiding this comment.
oh yes, of course!
auto-merge was automatically disabled
April 16, 2024 13:57
Pull Request is not mergeable
henrymercer
approved these changes
Apr 16, 2024
auto-merge was automatically disabled
April 16, 2024 14:10
Pull Request is not mergeable
|
The pull request is now mergeable :) |
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug when processing the changelog during a backport.
Merge / deployment checklist