-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build mode, Actions event name, and languages to the status report #2170
Conversation
@@ -79,6 +80,12 @@ export interface StatusReportBase { | |||
* telemetry tables. | |||
*/ | |||
job_run_uuid: string; | |||
/** | |||
* Comma-separated list of languages that analysis was run for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're now sending space-separated list rather than comma-separated: is that intentional? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch, agreed we should be sending comma-separated for consistency.
We can't use the "Rebuild" label on a PR with conflicts because the `pull_request` event runs on a synthetic merge commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR adds the build mode and Actions event name to the status report. We also record the languages for all first-party Actions rather than just
init
so that we can more easily use this for incident response.Merge / deployment checklist