Add common CLI configuration error categories #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested in github#2123 but was automerged before I could apply the suggestion
This clashes with the logic for the `NoJavaScriptTypeScriptCodeFound` case. Once that situation is deprecated, we can add the exit code back to `DetectedCodeButCouldNotProcess` configuration.
angelapwen
commented
Feb 13, 2024
henrymercer
reviewed
Feb 13, 2024
angelapwen
force-pushed
the
add-config-error-kinds
branch
from
be36887 to
8361861
Compare
henrymercer
previously approved these changes
Feb 13, 2024
Co-authored-by: Henry Mercer <[email protected]>
These tests will also result in the "No code found" error, but the functionality they test is unrelated, so we simply match against the bits we care about.
Except in the special case where we prepend the docs link, which is handled separately
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
henrymercer
reviewed
Feb 14, 2024
angelapwen
force-pushed
the
add-config-error-kinds
branch
from
fc1bd33 to
0bec49a
Compare
Co-authored-by: Henry Mercer <[email protected]>
angelapwen
force-pushed
the
add-config-error-kinds
branch
from
0bec49a to
3dc47a2
Compare
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We looked through recent telemetry errors and these were some of the most common failures we attribute to configuration errors. I've added them now that we have a nice place to do so!
Also, a couple of tiny drive-by improvements that I didn't think merited their own PRs.
Merge / deployment checklist