Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable analysis summary v2 and sub-language file coverage information on GHES #1967

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

henrymercer
Copy link
Contributor

This PR:

  • Enables analysis summary v2 on GHES 3.9 and later (since the new summary currently links to the status page unconditionally).
  • Enables sub-language file coverage information on the upcoming GHES 3.12 and later.
  • Cleans up the feature flag for exporting failed SARIF.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner October 25, 2023 18:53
src/codeql.ts Show resolved Hide resolved
src/feature-flags.ts Show resolved Hide resolved
angelapwen
angelapwen previously approved these changes Oct 26, 2023
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the 🧹 cleanup on failed SARIF too!

@henrymercer
Copy link
Contributor Author

Now I get an opportunity to use #1971 :)

@henrymercer henrymercer added the Rebuild Re-transpile JS & re-generate workflows label Oct 26, 2023
@github-actions github-actions bot removed the Rebuild Re-transpile JS & re-generate workflows label Oct 26, 2023
@henrymercer
Copy link
Contributor Author

Well, I'm not too surprised that didn't work. Pushing a fix.

@angelapwen
Copy link
Contributor

Ah.. I'd also thought that it'd check out the current branch by default, but it does make sense that the checkout action isn't aware of the current branch ref.

@henrymercer
Copy link
Contributor Author

Ah.. I'd also thought that it'd check out the current branch by default, but it does make sense that the checkout action isn't aware of the current branch ref.

I think it checks out the synthetic merge commit vs the head of the branch, and the latter is what we want to push to.

@henrymercer henrymercer merged commit 14d0fa9 into main Oct 27, 2023
337 checks passed
@henrymercer henrymercer deleted the henrymercer/enable-features-on-ghes branch October 27, 2023 08:29
@github-actions github-actions bot mentioned this pull request Oct 27, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants