Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the bundle upgrade #1630

Merged
merged 6 commits into from
Apr 3, 2023
Merged

Conversation

henrymercer
Copy link
Contributor

This PR automates the process of updating the default CodeQL Bundle. This minimises error, speeds up the release process, and lets us more easily make changes to how we represent the default CodeQL Bundle within the Action.

The workflow is triggered when a new bundle release is taken out of draft and made pre-release. It automatically opens a PR to bump the default bundle, and adds a changelog note. The CLI release manager then just needs to take this PR out of draft to run the checks, approve and merge.

Commit-by-commit review recommended — the first commit moves internal Actions into .github/actions which generates a large diff.

For GitHub staff, see an example Actions run and PR generated by this workflow.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner April 3, 2023 18:13
adityasharad
adityasharad previously approved these changes Apr 3, 2023
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Minor suggestions only, and we can always improve over time.

.github/actions/update-bundle/index.ts Outdated Show resolved Hide resolved
.github/actions/update-bundle/index.ts Outdated Show resolved Hide resolved
.github/workflows/update-bundle.yml Outdated Show resolved Hide resolved
adityasharad
adityasharad previously approved these changes Apr 3, 2023
@henrymercer henrymercer merged commit f0a422f into main Apr 3, 2023
@henrymercer henrymercer deleted the henrymercer/automate-bundle-upgrade branch April 3, 2023 19:07
@github-actions github-actions bot mentioned this pull request Apr 5, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants