Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for CODE_SCANNING_REF #1435

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Add tests for CODE_SCANNING_REF #1435

merged 2 commits into from
Dec 13, 2022

Conversation

orhantoy
Copy link
Contributor

We introduced CODE_SCANNING_REF in #1372 and #1368. This env will be used as a fallback if the GITHUB_REF is not set.

This PR adds tests for the changes introduced in the mentioned PRs so we can ensure that we do not break this behavior moving forward.

Question

Are we OK with this being a unit test? That's the approach I went with because GITHUB_REF is also tested like that.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary. N/A
  • Confirm the changelog has been updated if necessary. N/A

@orhantoy orhantoy requested a review from a team as a code owner December 13, 2022 11:58
@orhantoy orhantoy merged commit d58039a into main Dec 13, 2022
@orhantoy orhantoy deleted the orhantoy/add-CODE_SCANNING_REF-tests branch December 13, 2022 22:10
This was referenced Dec 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhantoy @aeisenberg