Update unset environment variables PR check #1269
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,80 @@ | ||||||
| name: PR Check - Test unsetting environment variables for CLI version < 2.5 | ||||||
|
angelapwen marked this conversation as resolved.
Outdated
|
||||||
| env: | ||||||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||||||
| GO111MODULE: auto | ||||||
| on: | ||||||
| push: | ||||||
| branches: | ||||||
| - main | ||||||
| - releases/v1 | ||||||
| - releases/v2 | ||||||
| pull_request: | ||||||
| types: | ||||||
| - opened | ||||||
| - synchronize | ||||||
| - reopened | ||||||
| - ready_for_review | ||||||
| workflow_dispatch: {} | ||||||
| jobs: | ||||||
| unset-environment: | ||||||
| strategy: | ||||||
| matrix: | ||||||
| include: | ||||||
| - os: ubuntu-latest | ||||||
| version: stable-20210308 | ||||||
| - os: ubuntu-latest | ||||||
| version: stable-20210319 | ||||||
| name: Test unsetting environment variables | ||||||
| timeout-minutes: 45 | ||||||
| runs-on: ${{ matrix.os }} | ||||||
| steps: | ||||||
| - name: Check out repository | ||||||
| uses: actions/checkout@v3 | ||||||
| - name: Prepare test | ||||||
| id: prepare-test | ||||||
| uses: ./.github/prepare-test | ||||||
| with: | ||||||
| version: ${{ matrix.version }} | ||||||
| - uses: ./../action/init | ||||||
| with: | ||||||
| languages: csharp,cpp,go,javascript,python | ||||||
| db-location: ${{ runner.temp }}/customDbLocation | ||||||
| tools: ${{ steps.prepare-test.outputs.tools-url }} | ||||||
| env: | ||||||
| TEST_MODE: true | ||||||
| - name: Build code | ||||||
| shell: bash | ||||||
| run: env -i PATH="$PATH" HOME="$HOME" ./build.sh | ||||||
| - uses: ./../action/analyze | ||||||
| id: analysis | ||||||
| env: | ||||||
| TEST_MODE: true | ||||||
| - shell: bash | ||||||
| run: | | ||||||
| CPP_DB=${{ fromJson(steps.analysis.outputs.db-locations).cpp }} | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
Contributor
Author
There was a problem hiding this comment. I'm curious — why does
Contributor
There was a problem hiding this comment. When you are defining a bash variable, you don't need quotes around its name, only its value. When you are using a bash variable, it should always be quoted. If you don't quote at the appropriate times, whitespace will be considered separate arguments.
Contributor
There was a problem hiding this comment. Here's an example. Let's say This command: will be interpreted as setting the variable Will simply set the
Contributor
Author
There was a problem hiding this comment. Thanks for the example, that helps! I didn't realize that. Makes sense as to why the variable doesn't need quotes when it's being defined, then. |
||||||
| if [[ ! -d $CPP_DB ]] || [[ ! $CPP_DB == ${{ runner.temp }}/customDbLocation/* ]]; then | ||||||
|
angelapwen marked this conversation as resolved.
Outdated
|
||||||
| echo "Did not create a database for CPP, or created it in the wrong location." | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
Contributor
Author
There was a problem hiding this comment. Interesting, I actually read the test differently — I thought expected would be at
Contributor
There was a problem hiding this comment. Ah...apologies. You might be right here. |
||||||
| exit 1 | ||||||
| fi | ||||||
| CSHARP_DB=${{ fromJson(steps.analysis.outputs.db-locations).csharp }} | ||||||
| if [[ ! -d $CSHARP_DB ]] || [[ ! $CSHARP_DB == ${{ runner.temp }}/customDbLocation/* ]]; then | ||||||
| echo "Did not create a database for C Sharp, or created it in the wrong location." | ||||||
| exit 1 | ||||||
| fi | ||||||
| GO_DB=${{ fromJson(steps.analysis.outputs.db-locations).go }} | ||||||
| if [[ ! -d $GO_DB ]] || [[ ! $GO_DB == ${{ runner.temp }}/customDbLocation/* ]]; then | ||||||
| echo "Did not create a database for Go, or created it in the wrong location." | ||||||
| exit 1 | ||||||
| fi | ||||||
| JAVASCRIPT_DB=${{ fromJson(steps.analysis.outputs.db-locations).javascript }} | ||||||
| if [[ ! -d $JAVASCRIPT_DB ]] || [[ ! $JAVASCRIPT_DB == ${{ runner.temp }}/customDbLocation/* ]]; then | ||||||
| echo "Did not create a database for Javascript, or created it in the wrong location." | ||||||
| exit 1 | ||||||
| fi | ||||||
| PYTHON_DB=${{ fromJson(steps.analysis.outputs.db-locations).python }} | ||||||
| if [[ ! -d $PYTHON_DB ]] || [[ ! $PYTHON_DB == ${{ runner.temp }}/customDbLocation/* ]]; then | ||||||
| echo "Did not create a database for Python, or created it in the wrong location." | ||||||
| exit 1 | ||||||
| fi | ||||||
| env: | ||||||
| INTERNAL_CODEQL_ACTION_DEBUG_LOC: true | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much we can do about this, but we will need to remember to change this when we no longer support CLI v2.5.9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agreed (it's also present in all the other PR checks so we can change them all at once).