Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use explicit workflow for codeql instead of automatic scans #157

Closed
wants to merge 1 commit into from

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Nov 1, 2024

Pull Request

This should reduce the number of times we have all checks passing but codeql doesn't work and we cant merge a pr without bypassing security requirements.

Proposed Changes

This pull request introduces a new GitHub Actions workflow for advanced CodeQL analysis. The most important changes include setting up the workflow to run on specific events, configuring the job matrix for Python, and integrating the CodeQL tools for scanning.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@zkoppert
Copy link
Member Author

zkoppert commented Nov 1, 2024

CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled Well thats a fail. Looks like the feature isn't going to consistently work for us.

@zkoppert zkoppert closed this Nov 1, 2024
@zkoppert zkoppert deleted the zkoppert-patch-1 branch November 1, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants