Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the sidebar scrollable above 768px #305

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

rik
Copy link
Contributor

@rik rik commented Feb 11, 2023

I tested those changes in the devtools but I did not build the docs to check (it would be nice to have instructions on how to contribute)

@rik rik requested a review from a team as a code owner February 11, 2023 16:08
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

Copy link
Contributor

@josepmartins josepmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rik, looks good to me! ✨

We have a contributing doc for contributions. Other than that, the doc site is a Jekyll project, so to run it locally you'll need to cd docs & bundle exec jekyll serve

@josepmartins josepmartins merged commit cd2c17e into github:main Feb 13, 2023
@rik rik deleted the scrollable-sidebar branch February 13, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants