Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazyDefine components #268

Merged
merged 21 commits into from
Aug 4, 2022
Merged

lazyDefine components #268

merged 21 commits into from
Aug 4, 2022

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Aug 1, 2022

Upstream a lazyDefine function from github/github and add some tests.

@koddsson koddsson requested a review from a team as a code owner August 1, 2022 16:34
@koddsson koddsson requested a review from srt32 August 1, 2022 16:34
koddsson
koddsson commented Aug 2, 2022
View reviewed changes
src/lazy-define.ts Outdated Show resolved Hide resolved
src/lazy-define.ts Show resolved Hide resolved
src/lazy-define.ts Outdated Show resolved Hide resolved
test/lazy-define.ts Outdated Show resolved Hide resolved
test/lazy-define.ts Outdated Show resolved Hide resolved
@keithamus
Copy link
Member

This looks good, we should add some documentation and export it from index 😆

koddsson and others added 21 commits August 4, 2022 11:55
@koddsson @keithamus
Copy lazy-define.ts from github/github
061a038 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Listen to readystatechange instead of DOMContentLoaded
926d61b 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Add more event listeners for interaction check
57148d0 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Use abort controller to remove event handlers
49b4cc0 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Observe elements when whenSeen is called
612cc18 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Convert callback Array to a Set
065bde1 
This prevents callbacks being called twice or more for a given dynamic
element.

Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Pass in the element tag name to strategies
f6489c9 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Add a visible strategy
2e858fb 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Rename whenSeen to lazyDefine
d790e4b 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Check actual object rather than string
943c929 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Add tests for addStrategy
ec912f2 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Add some basic tests for lazyDefine
a0c45c4 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Scan whole document on each lazyDefine
1b509ca 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
prettier
d540098 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Add test to make sure callbacks are only called once
8e9da7d 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Add tests for the different strategies
702fe87 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Disable wrong eslint rule
df33984 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson
Remove addStrategy function
d81a887
@koddsson
Remove default document.body from function signature
9fc890b
@koddsson @keithamus
Export lazyDefine in index
84621ef 
Co-authored-by: Keith Cirkel <[email protected]>
@koddsson @keithamus
Add documentation for lazyDefine
f0e572e 
Co-authored-by: Keith Cirkel <[email protected]>
@keithamus keithamus merged commit e81d778 into main Aug 4, 2022
@keithamus keithamus deleted the lazy-define branch August 4, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

@srt32 srt32 Awaiting requested review from srt32 srt32 was automatically assigned from github/web-systems-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koddsson @keithamus