Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amend attr tests to use two word attrs #230

Merged
merged 1 commit into from
May 11, 2022

Conversation

keithamus
Copy link
Member

2.0 will drop the data- attribute prefix, and mandate two-word attributes (so that they include a -). This test lays some ground work by minimising the 2.0 diff. All tests now feature two word attributes, but the tests have the data- prefix still.

@keithamus keithamus requested a review from a team as a code owner May 10, 2022 15:52
@keithamus keithamus requested a review from theinterned May 10, 2022 15:52
@keithamus keithamus changed the title ammend attr tests to use two word attrs amend attr tests to use two word attrs May 10, 2022
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@keithamus keithamus merged commit 5508963 into main May 11, 2022
@keithamus keithamus deleted the ammend-attr-tests-to-use-two-word-attrs branch May 11, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants