fix: prevent invalid contributor footer markup - #2608
Merged
Conversation
Disable the all-contributors usage footer because the pinned CLI emits an invalid closing img tag. Keep the usage link outside the generated contributor block. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 936cc10e-06f7-440c-96e7-51d1e94476ce
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents contributor generation from reintroducing invalid Astro image markup.
Changes:
- Disables the generated all-contributors usage footer.
- Adds stable contribution links outside generated blocks.
- Removes invalid footer markup from contributor pages.
Show a summary per file
| File | Description |
|---|---|
.all-contributorsrc |
Disables generated usage footers. |
README.md |
Moves the contribution link outside the generated block. |
website/src/pages/contributors.astro |
Replaces generated footer markup with valid Astro markup. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor PRs currently regenerate an invalid
</img>tag in the website contributor page, causing Astro builds to fail. The pinnedall-contributors-cliversion hardcodes this tag in its usage footer.This change disables that generated footer and keeps the contribution link outside the generated contributor block, so future contributor updates cannot reintroduce invalid Astro markup. The README and website page are updated consistently.
The full website build could not be run locally because dependency installation is blocked by an unavailable internal
@github/copilot@1.0.78package.