Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nim grammar to support the new number literals #5306

Merged
merged 6 commits into from
Apr 6, 2021

Conversation

timotheecour
Copy link
Contributor

@timotheecour timotheecour commented Apr 1, 2021

update nim syntax to support the new number literals, eg:

# currently appear broken, but fixed with this PR
let a = 12'big
let b = 13'big

Description

  • https://github.com/Varriount/NimLime hasn't been updated in over 2 years, and a new feature in nim (number literals) renders really badly with existing grammar (causing subsequent line to render badly). This PR updates the submodule url and fixes the rendering of new number literals

Checklist:

note that I'm also adding a new file samples/Nim/main.nim which illustrates all existing nim syntax including the new number literals which currently show up incorrectly but are being fixed via this PR

I've previously contributed to this repo for nim syntax (see #4295)

links

/cc @JohnAD @Varriount

@timotheecour timotheecour requested a review from a team as a code owner April 1, 2021 20:28
@timotheecour timotheecour changed the title update nim syntax to support the new number literals update nim grammar to support the new number literals Apr 1, 2021
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇

@lildude lildude merged commit 9f717cc into github-linguist:master Apr 6, 2021
@timotheecour timotheecour deleted the pr_linguist_nim_numlit branch April 6, 2021 07:31
@timotheecour
Copy link
Contributor Author

@lildude thanks! when will those changes be reflected? the snippet on top of this PR still appears broken, is there a place where i can know when the next release will happen?

@lildude
Copy link
Member

lildude commented Apr 6, 2021

Changes don't appear automatically. They only appear when a new release is made and I'm in the process of testing the next release for release this week. You can follow along in #5305

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants