Don't require linguist/repository #1600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linguist/repository depends on the Rugged gem, which isn't included in the github-linguist dependencies. Applications and libraries using linguist/repository can still use it by manually calling `require 'linguist/repository'`
calebhearth
added a commit
to calebhearth/html-pipeline
that referenced
this pull request
Oct 16, 2014
Currently this also catches a LoadError for rugged, a dependency Linguist added but didn't add to its gemspec. github-linguist/linguist#1600 github-linguist/linguist#1601
|
Thanks for these @calebthompson - definitely favour #1601over this. I'm just trying to figure out why we moved the rugged dependency out of the gemspec in the first place. |
|
:( okay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linguist/repository depends on the Rugged gem, which isn't included in the
github-linguist dependencies.
Applications and libraries using linguist/repository can still use it by
manually calling
require 'linguist/repository'This is option 1. Opening a parallel pull request to add a Rugged dependency.
This is my preferred approach since it doesn't add a new dependency, but
strictly speaking it also means that we need to bump the major version since
Linguist::Repository is no longer defined.
The reason for this change is that a 3rd-party with "require 'linguist'" gets a
load error for Rugged being missing since it is required in linguist/repository.