Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to nuxt3 #144

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Move to nuxt3 #144

wants to merge 13 commits into from

Conversation

karpikpl
Copy link
Collaborator

@karpikpl karpikpl commented Jan 24, 2025

Updated code to use Nuxt3.
Resolved all old dependencies.

I tried to keep as much backward compatibility as possible:

  • kept old port
  • kept environment variable names

Warning

One breaking change is required to have NUXT_SESSION_PASSWORD (at least 32 characters long) which is used to encrypt session cookies.

This pull request includes several changes to improve the deployment process, update environment variables, and streamline the Docker configuration. The most important changes include modifications to .env variables, Dockerfile updates, and workflow adjustments.

Environment Variables Update:

  • Updated environment variables in .env to use NUXT_PUBLIC prefix instead of VUE_APP, and added new variables for GitHub OAuth and session password.

Docker Configuration:

  • Updated Dockerfile to support different build modes (prod and playwright) and re-mapped environment variables for backwards compatibility.

Workflow Adjustments:

  • Simplified GitHub workflows by removing redundant steps and adding new steps for building and testing the application. Changes include removing push_proxy_to_ghcr job and updating metadata-action configurations. [1] [2] [3] [4] [5] [6] [7]
  • Updated Playwright workflow to include a build step and consolidated Docker-based Playwright tests. [1] [2]

Documentation:

  • Updated DEPLOYMENT.md to reflect changes in environment variables and deployment options, and removed references to the legacy -with-proxy image. [1] [2] [3] [4]

Miscellaneous:

  • Added .vscode/launch.json for debugging configurations in Visual Studio Code.

@karpikpl karpikpl requested a review from martedesco January 24, 2025 06:15
@karpikpl
Copy link
Collaborator Author

Hey @martedesco - sending this for initial review

server/modules/authentication.ts Dismissed Show dismissed Hide dismissed
@karpikpl karpikpl requested a review from Copilot January 27, 2025 23:05
@karpikpl karpikpl marked this pull request as ready for review January 27, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant