Bugfix: undefined method line_labels_for #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
@ferrarimarco ping |
|
Thanks for this PR! Can you please add a test case for this as well? |
ferrarimarco
suggested changes
Feb 11, 2020
|
ping, any update on this? |
|
@ferrarimarco ping |
|
@olleolleolle can you have a look at this as well? Thanks! |
| @@ -7,7 +7,7 @@ module GitHubChangelogGenerator | |||
| # | |||
| # @see GitHubChangelogGenerator::Entry | |||
| class Section | |||
| attr_accessor :name, :prefix, :issues, :labels, :body_only | |||
| attr_accessor :name, :options, :prefix, :issues, :labels, :body_only | |||
There was a problem hiding this comment.
If we're not using the setter, can :options become a attr_reader?
| @@ -49,7 +49,7 @@ def get_string_for_issue(issue) | |||
| encapsulated_title = encapsulate_string issue["title"] | |||
|
|
|||
| title_with_number = "#{encapsulated_title} [\\##{issue['number']}](#{issue['html_url']})" | |||
| title_with_number = "#{title_with_number}#{line_labels_for(issue)}" if @options[:issue_line_labels].present? | |||
| title_with_number = "#{title_with_number}#{Entry.new(options).line_labels_for(issue)}" if @options[:issue_line_labels].present? | |||
There was a problem hiding this comment.
Perhaps later, one can build an @entry to be used to repeatedly make the line_labels_for call on?
olleolleolle
approved these changes
Apr 10, 2020
|
@ferrarimarco So, one way to deal with the code notes that I mentioned in my ✅ passing review is that we make them, when this has landed in master. |
ferrarimarco
approved these changes
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you specify option
issue-line-labelsin your.github_changelog_generatorit will throw:This is fix for it.