Credit line bug #535
Merged
Credit line bug #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Is it possible to figure out a test for this? |
Lucashuang0802
commented
Jun 27, 2017
| @@ -21,7 +21,8 @@ def compound_changelog | |||
|
|
|||
| log += File.read(options[:base]) if File.file?(options[:base]) | |||
|
|
|||
| log += "\n\n\\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*" | |||
| credit_line = "\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*" | |||
| log += "\n\n\#{credit_line}" if log.include? credit_line == false | |||
There was a problem hiding this comment.
@olleolleolle do you know where the extra ''? Should it be "\n\n#{credit_line}"?
|
@olleolleolle perhaps we can check there is only one |
|
For an integration test approach:
Then, as a follow-up (next) feature:
The second test would be about mending, repairing, fixing CHANGELOG.md files in the wild that have used earlier versions of the code, or are using the |
This was referenced Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #507. @olleolleolle please give a review. 馃槂