Replace GPL'd colorize gem with MIT-licensed rainbow #408
Conversation
colorize is licensed under GPL-2 which conflicts with the MIT license of github_changelog_generator. This changes all usage of colorize to rainbow which does have a compatible license (MIT)
|
Hello James! Good choice of library. I wonder: we're coloring strings that pass through our |
|
@jamesc Hi! I made my comment into a PR-onto-your-PR. |
|
@jamesc Oh, I made a change, again. |
- The central logging method decides the color of the output - pass Rubocop complaints
- do not include all the rainbow presenter methods directly in the
String class
| @@ -27,6 +27,9 @@ Gem::Specification.new do |spec| | |||
| spec.add_runtime_dependency "github_api", ">= 0.12" | |||
| spec.add_runtime_dependency "rainbow", ">= 2.1" | |||
|
|
|||
| # rack 2.0 does not work on Ruby < 2.2. Lock it down here | |||
| spec.add_runtime_dependency "rack", "~> 1.2" | |||
There was a problem hiding this comment.
This is contentious: if people are using this library in their application, we're holding the rack back.
More to the point: people are using it in their applications, and I want us to find a way to make Ruby versions < 2.2 have a rack which is installable for them, while keeping users with 2.2+ happy.
|
Yeah, I backed out that change. It doesn't fix the travis builds anyway. I'll look at how we might be able to fix the builds in a separate branch. |
|
@jamesc Cool, thanks for your hard effort! This change fixes a hard problem, and we got the logging mechanism placed more centrally, by only using its formatter. And we got rid of the String extension, which the colorize gem also had. To make the PR really stand out in the changelog, do you want to rephrase the title of it? Since we will be making a CHANGELOG.md out of this, I want this PR to be called something clearer (for understanding at a glance). Examples include:
|
jamesc
changed the title
|
Again, thanks a lot for doing this, @jamesc! 🎉 |
colorize is licensed under GPL-2 which conflicts with the MIT license of
github_changelog_generator. This changes all usage of colorize to
rainbow which does have a compatible license (MIT)