ParserFile: Allow comments in settings file #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
force-pushed
the
feature/parserfile-allow-comments
branch
2 times, most recently
from
adc1695
to
cc0b5eb
Compare
- Ruby-style or semi-colon-style accepted
olleolleolle
force-pushed
the
feature/parserfile-allow-comments
branch
from
cc0b5eb
to
4569fad
Compare
|
It just occurred to me: a blank line, or a line of only whitespace, should also be skipped and ignored (not a failure). |
- defined as: lines that consist only of whitespace
|
OK, @skywinder - ready for review! |
| option_name, value = extract_pair(line) | ||
| @options[option_key_for(option_name)] = convert_value(value, option_name) | ||
| rescue | ||
| raise ParserError, "Failed on line ##{line_number}: \"#{line.gsub(/[\n\r]+/, '')}\"" | ||
| end | ||
|
|
||
| # Returns true if the line starts with a pound sign or a semi-colon. | ||
| def non_configuration_line?(line) | ||
| line =~ /^[\#;]/ || line =~ /^[\s]+$/ |
There was a problem hiding this comment.
All good. Just question about ";"-comment syntax:
Why strings, starts from ; should specified as comment?
First time, when see such syntax.
There was a problem hiding this comment.
INI files have those comments?
skywinder
added a commit
that referenced
this pull request
Mar 21, 2016
…mments ParserFile: Allow comments in settings file
|
Got it! Git it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.github_changelog_generatorsettings file.Other non-setting-like lines are still reported as failures to parse.