Expose dataplane log level controls through Gateway CRD #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR exposes dataplane log level controls through the Gateway CRD, allowing users to configure logging levels for gateway dataplanes via Kubernetes resources instead of hardcoded values.
Key changes:
- Added GatewayLogs struct with configurable default and tag-based log levels
- Replaced hardcoded DEBUG log level with configurable tracing settings
- Updated dependencies to support new logging configuration
Reviewed Changes
Copilot reviewed 7 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/gateway/v1alpha1/gateway_types.go | Defines new GatewayLogs struct and GatewayLogLevel enum with validation |
| pkg/agent/dataplane.go | Implements log level configuration mapping and removes hardcoded DEBUG level |
| config/crd/bases/*.yaml | Updates CRD schemas to include new logs configuration fields |
| docs/api.md | Documents new GatewayLogs and GatewayLogLevel API types |
| go.mod | Updates gateway-proto dependency to support new logging features |
| api/gateway/v1alpha1/zz_generated.deepcopy.go | Auto-generated deepcopy methods for new types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This is an automated commit created by GitHub Actions workflow, in the gateway-proto repository. Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Sergei Lukianov <[email protected]>
Fixes #187 Signed-off-by: Sergei Lukianov <[email protected]>
Frostman
force-pushed
the
dev/frostman/loglevel
branch
from
8d2288c to
bf98e0b
Compare
|
🚀 Temp artifacts published: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.