Skip to content

Conversation

mvachhar
Copy link
Contributor

@mvachhar mvachhar commented Oct 9, 2025

Adds nat configuration options to the expose blocks in gRPC.

Does not Fix #73

@mvachhar mvachhar requested a review from Copilot October 9, 2025 14:32
@mvachhar mvachhar self-assigned this Oct 9, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for NAT (Network Address Translation) configuration in gRPC expose blocks by introducing stateful and stateless NAT types with optional timeout support.

  • Introduces new PeeringStatefulNAT and PeeringStatelessNAT message types to the protobuf definition
  • Adds a nat oneof field to the Expose message to support both NAT types
  • Creates duration conversion utilities for protobuf-to-std time duration handling

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/lib.rs Adds new duration module reference
src/duration.rs Implements conversion utilities between protobuf and std Duration types
src/bolero/expose.rs Adds TypeGenerator implementations for NAT types and updates Expose generation
proto/dataplane.proto Defines new NAT message types and adds nat field to Expose
pkg/dataplane/dataplane.pb.go Generated Go code for new NAT protobuf messages
build.rs Updates TypeGenerator configuration for test builds
Cargo.toml Adds thiserror dependency and bolero dev dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Frostman
Frostman previously approved these changes Oct 9, 2025
@mvachhar mvachhar force-pushed the pr/mvachhar/nat-config branch from 97aa4b3 to b4149f8 Compare October 9, 2025 21:40
@mvachhar mvachhar requested a review from Copilot October 10, 2025 14:55
@mvachhar mvachhar marked this pull request as ready for review October 10, 2025 14:55
@mvachhar mvachhar force-pushed the pr/mvachhar/nat-config branch from 05c6265 to 1e4a142 Compare October 10, 2025 14:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 10 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mvachhar mvachhar force-pushed the pr/mvachhar/nat-config branch from 1e4a142 to 246fe65 Compare October 10, 2025 15:01
@qmonnet qmonnet self-requested a review October 10, 2025 15:14
@mvachhar mvachhar requested a review from Frostman October 10, 2025 15:14
@Frostman
Copy link
Member

I'll give a chance @qmonnet to take a look as well as he self-requested review just 2h ago

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, thanks!

@Frostman Frostman merged commit e2b4480 into master Oct 13, 2025
6 checks passed
@Frostman Frostman deleted the pr/mvachhar/nat-config branch October 13, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add stateful NAT configuration to gateway agent

3 participants