-
Notifications
You must be signed in to change notification settings - Fork 1
Add support for nat configuration in gRPC #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for NAT (Network Address Translation) configuration in gRPC expose blocks by introducing stateful and stateless NAT types with optional timeout support.
- Introduces new
PeeringStatefulNAT
andPeeringStatelessNAT
message types to the protobuf definition - Adds a
nat
oneof field to theExpose
message to support both NAT types - Creates duration conversion utilities for protobuf-to-std time duration handling
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/lib.rs | Adds new duration module reference |
src/duration.rs | Implements conversion utilities between protobuf and std Duration types |
src/bolero/expose.rs | Adds TypeGenerator implementations for NAT types and updates Expose generation |
proto/dataplane.proto | Defines new NAT message types and adds nat field to Expose |
pkg/dataplane/dataplane.pb.go | Generated Go code for new NAT protobuf messages |
build.rs | Updates TypeGenerator configuration for test builds |
Cargo.toml | Adds thiserror dependency and bolero dev dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
4bcc3c0
to
97aa4b3
Compare
97aa4b3
to
b4149f8
Compare
Signed-off-by: Manish Vachharajani <[email protected]>
05c6265
to
1e4a142
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 10 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Manish Vachharajani <[email protected]>
Signed-off-by: Manish Vachharajani <[email protected]>
1e4a142
to
246fe65
Compare
I'll give a chance @qmonnet to take a look as well as he self-requested review just 2h ago |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, thanks!
Adds nat configuration options to the expose blocks in gRPC.
Does not Fix #73